Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Configuration Avoidance fixes #117

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

joshafeinberg
Copy link
Member

@joshafeinberg joshafeinberg commented Feb 16, 2022

Fixes #115

Sample app saw the following improvements:

16 tasks created vs 38 (-58%)
0.009s decrease in time to configure (-37.5%)

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #117 (4d428cb) into main (897934e) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 4d428cb differs from pull request most recent head 8e23643. Consider uploading reports for the commit 8e23643 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #117   +/-   ##
=========================================
  Coverage     50.55%   50.55%           
  Complexity       59       59           
=========================================
  Files            12       12           
  Lines           451      451           
  Branches         91       91           
=========================================
  Hits            228      228           
  Misses          196      196           
  Partials         27       27           
Impacted Files Coverage Δ
...ctedmoduledetector/AffectedModuleDetectorPlugin.kt 44.26% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897934e...8e23643. Read the comment docs.

Copy link
Contributor

@chris-mitchell chris-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add some notes about the performance improvement you saw with this?

@joshafeinberg
Copy link
Member Author

Thanks! Can you add some notes about the performance improvement you saw with this?

Updated the description with notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AffectedModuleDetectorPlugin is eagerly creating tasks at configuration time
2 participants