Feature: New approach for creating custom command for impact analysis #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Evleaps
commented
Apr 5, 2022
...ledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt
Outdated
Show resolved
Hide resolved
...or/src/main/kotlin/com/dropbox/affectedmoduledetector/plugin/AffectedModuleDetectorPlugin.kt
Outdated
Show resolved
Hide resolved
...detector/src/main/kotlin/com/dropbox/affectedmoduledetector/plugin/AffectedModuleTaskType.kt
Outdated
Show resolved
Hide resolved
...ledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
============================================
+ Coverage 49.78% 53.69% +3.91%
- Complexity 58 68 +10
============================================
Files 12 13 +1
Lines 462 514 +52
Branches 96 97 +1
============================================
+ Hits 230 276 +46
- Misses 207 212 +5
- Partials 25 26 +1
Continue to review full report at Codecov.
|
joshafeinberg
approved these changes
May 5, 2022
vlsi
reviewed
Aug 17, 2022
| * @see CustomTask - Implementation class | ||
| * @see AffectedModuleDetectorPlugin - gradle plugin | ||
| */ | ||
| var customTasks = emptySet<AffectedModuleConfiguration.CustomTask>() |
There was a problem hiding this comment.
This should better use DomainObject APIs. I've created #161 for tracking that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My name is Roman.
You can write me:
Twiter: @Evleaps
WhatApp: +79056609998
Description
Creating of new gradle task with impact analysis is qiute complex task.
Need to create buildSrc and custom plugin, but it might be not trivial knowledge for general people. This mean that people can decline using this library due to complexety of extention. Also, using buildSrc quite complex, developers can make some mistakes which will rebuild all dependencies. Hence, a build time might be increased.
Problem:
Add new gradle command quite complex.
Solution
Share interface to developers. They can add customTasks in configuration without buildSrc.
NOTE
Please, start your review from
readme.md