Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code to better support when running project with configuration cache #144

Merged
merged 1 commit into from
May 12, 2022

Conversation

joshafeinberg
Copy link
Member

This PR has two fixes

  1. We no longer capture the project in our afterEvaluate statement
  2. Now if the affected module detector is not enabled, we don't check to see if the project is affected when deciding to run the task

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #144 (1a56982) into main (6c2b902) will decrease coverage by 0.20%.
The diff coverage is 14.28%.

❗ Current head 1a56982 differs from pull request most recent head 6897aa6. Consider uploading reports for the commit 6897aa6 to get more accurate results

@@             Coverage Diff              @@
##               main     #144      +/-   ##
============================================
- Coverage     53.69%   53.48%   -0.21%     
  Complexity       68       68              
============================================
  Files            13       13              
  Lines           514      516       +2     
  Branches         97       98       +1     
============================================
  Hits            276      276              
- Misses          212      214       +2     
  Partials         26       26              
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 40.65% <ø> (ø)
...ctedmoduledetector/AffectedModuleDetectorPlugin.kt 50.00% <14.28%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2b902...6897aa6. Read the comment docs.

@joshafeinberg joshafeinberg merged commit 1c807f0 into main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants