Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch registering tasks to lazy #170

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Switch registering tasks to lazy #170

merged 1 commit into from
Oct 31, 2022

Conversation

joshafeinberg
Copy link
Member

Switches the task registration to be lazy. This was broken by the call to .get() but now seems to handle better

Previous build scan: https://scans.gradle.com/s/n4zr3vwp5elaa/performance/configuration

  • 0.024s to apply plugin
  • 17 tasks created

Build scan after changes: https://scans.gradle.com/s/4j4n4rie4siwu/performance/configuration

  • 0.005s to apply plugin
  • 0 tasks created

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #170 (0563972) into main (f041be2) will increase coverage by 0.94%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##               main     #170      +/-   ##
============================================
+ Coverage     50.37%   51.32%   +0.94%     
- Complexity       66       71       +5     
============================================
  Files            13       13              
  Lines           532      530       -2     
  Branches         99      100       +1     
============================================
+ Hits            268      272       +4     
+ Misses          237      231       -6     
  Partials         27       27              
Impacted Files Coverage Δ
...ctedmoduledetector/AffectedModuleDetectorPlugin.kt 56.12% <77.77%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshafeinberg joshafeinberg merged commit ae455b5 into main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants