Support exotic gradle projects #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use p for Gradle projects and d for File directories on disk. We could have used any identifier but choosing the same letter is a bit of a mind bender for newbies that are not familiar. We also change the diagram to better match how the code sets up the projects.
|
As expected the failing tests fail because in this commit we haven't added the appropriate support.
|
This provides support for quixotic projects.
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
============================================
+ Coverage 53.09% 53.17% +0.08%
Complexity 73 73
============================================
Files 16 16
Lines 550 551 +1
Branches 99 100 +1
============================================
+ Hits 292 293 +1
Misses 232 232
Partials 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Woohoo! The checks pass! |
|
Alright, this seems good. We use fully qualified paths for all our external stuff so it was a bit harder for me to see what you were mentioning in the ticket but now with this we can support relative paths |
joshafeinberg
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will eventually fixfixes #174however for the time being this only doesby doing the following:AffectedModuleDetectorImplTestdand the Gradle project references top. We could have chosen any identifier but it was a little confusing for me that they were both the same not being familiar with the Gradle test tooling.".."markers in the relative project paths so that we can directly compare the Git with Gradle.Here's a picture of how one might set up Gradle in this weird... quixotic..... way. (Excuse the typo in the screenshot 😄 )
The project is declared in the same way but it's location is changed from the default location. Perfectly valid in Gradle..... not very common.... and not (yet) supported in AMD. After this change we will be able to support both.