Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exclude by regex #181

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Allow exclude by regex #181

merged 1 commit into from
Dec 1, 2022

Conversation

blundell
Copy link
Contributor

@blundell blundell commented Nov 23, 2022

For a module like :a:b:c:d

the name is "d" and the path is ":a:b:c:d".

You could now exclude using multiple styles:

excludedModules = [
   "d",
   ":a:b:c:d",
   ":.+:d",
]

(you would just use one of the 3 above strings.)

- Previously you could exclude by module name (#54)
- Now you can still exclude by module name but also exclude against module path using a regex

For a module like ``:a:b:c:d`

the name is "d" and the path is ":a:b:c:d".

You could now exclude using multiple styles:

```
excludedModules = [
   "d",
   ":a:b:c:d",
   ":.+:d",
]
```
(you would just use one of the 3 above strings.)
@blundell blundell mentioned this pull request Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #181 (baa9a7c) into main (cbc026c) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #181      +/-   ##
============================================
+ Coverage     53.09%   53.26%   +0.16%     
  Complexity       73       73              
============================================
  Files            16       16              
  Lines           550      552       +2     
  Branches         99      100       +1     
============================================
+ Hits            292      294       +2     
  Misses          232      232              
  Partials         26       26              
Impacted Files Coverage Δ
...x/affectedmoduledetector/AffectedModuleDetector.kt 43.57% <100.00%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshafeinberg
Copy link
Member

Thanks for the addition!

@joshafeinberg joshafeinberg merged commit 2c16c05 into dropbox:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants