Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration to before project evaluation #245

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

joshafeinberg
Copy link
Member

Also makes getInstance return null instead of crashing if extension isn't created yet. If wanting to crash, getOrThrow is the better method.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (312b8e0) 53.42% compared to head (999e792) 55.24%.

Files Patch % Lines
...x/affectedmoduledetector/AffectedModuleDetector.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #245      +/-   ##
============================================
+ Coverage     53.42%   55.24%   +1.81%     
  Complexity       73       73              
============================================
  Files            16       16              
  Lines           569      572       +3     
  Branches        104      104              
============================================
+ Hits            304      316      +12     
+ Misses          237      225      -12     
- Partials         28       31       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpaleop
Copy link

cpaleop commented Mar 18, 2024

Any updates here? We are kind of eager to test the new release - more specifically #240

@joshafeinberg joshafeinberg merged commit c67c042 into main Mar 18, 2024
5 of 6 checks passed
@joshafeinberg joshafeinberg deleted the jfein/config-fix branch March 18, 2024 20:04
@joshafeinberg
Copy link
Member Author

Any updates here? We are kind of eager to test the new release - more specifically #240

Should be released shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants