Move to Gradle publish plugin #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
changusmc
commented
Dec 10, 2021
changusmc
commented
- Move to Gradle publish plugin
- Remove release scripts
| @@ -43,7 +43,7 @@ class AffectedModuleDetectorPluginTest { | |||
| throw IllegalStateException("Expected to throw exception") | |||
| } catch (e: PluginApplicationException) { | |||
| // THEN | |||
| assertThat(e.message).isEqualTo("Failed to apply plugin [class 'com.dropbox.affectedmoduledetector.AffectedModuleDetectorPlugin']") | |||
| assertThat(e.message).isEqualTo("Failed to apply plugin class 'com.dropbox.affectedmoduledetector.AffectedModuleDetectorPlugin'.q") | |||
There was a problem hiding this comment.
nit: i think the .q is unnecessary?
chris-mitchell
approved these changes
Dec 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
=========================================
Coverage 50.22% 50.22%
Complexity 54 54
=========================================
Files 12 12
Lines 450 450
Branches 95 95
=========================================
Hits 226 226
Misses 194 194
Partials 30 30 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.