This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Fix #38 #145
Open
Fix #38 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse the number according to the JSON grammar, ignoring the current locale.
artwyman
suggested changes
Jan 27, 2020
| * Parse the number according to the JSON grammar, ignoring the current locale assuming that the | ||
| * string is already validated to comply with the JSON grammar. | ||
| */ | ||
| double strtod_dot(const char* str) { |
There was a problem hiding this comment.
This seems like a good approach, but I don't see it called anywhere. You probably meant to call it in parse_number().
| @@ -252,6 +252,18 @@ JSON11_TEST_CASE(json11_test) { | |||
|
|
|||
| } | |||
|
|
|||
| JSON11_TEST_CASE(json11_test_numbers) { | |||
| const std::string numbers = | |||
There was a problem hiding this comment.
This needs to override the locale in order to really test what you intend.
| const std::string numbers_json = Json::parse(numbers, err).dump(); | ||
| std::cout << "numbers_json: " << numbers_json << std::endl; | ||
| JSON11_TEST_ASSERT(numbers_json == expected_numbers); | ||
| } |
There was a problem hiding this comment.
Should also test round-trip back to string to ensure no locale issues there.
|
Thanks for your effort! This repo is no longer supported by Dropbox and about to be archived. I'm not going to try to merge this PR at the last minute, but I'll leave it open for reference by anyone who encounters the same problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the number according to the JSON grammar, ignoring the current
locale.