Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support persisting cookies from multiple domains #314

Merged
merged 30 commits into from
Sep 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3b0aaae
support persisting cookies from multiple domains
ducaale May 29, 2023
903c9d6
store cookie domain in session
ducaale Jun 10, 2023
7ad0b54
test new style cookie parsing
ducaale Jun 10, 2023
156cf03
fix existing tests
ducaale Jun 10, 2023
eed5d43
default to request host if cookie domain missing
ducaale Jun 11, 2023
5d82351
add todos
ducaale Jun 11, 2023
368bcf9
enable cookie_store's preserve_order feature
ducaale Jun 13, 2023
f439fda
add todos
ducaale Jun 13, 2023
3ac20ea
fix useless_conversion clippy warning
ducaale Jun 13, 2023
0073081
revert defaulting to request host for domain
ducaale Jun 17, 2023
3cc1fff
update cookie_store and its peer dependencies
ducaale Jun 17, 2023
f30f73f
ensure stored cookies always have a domain
ducaale Jun 17, 2023
31aaa90
load all cookies regardless of their domain
ducaale Jun 17, 2023
ef841b0
ensure cookie's domain attribute is not IP
ducaale Jun 17, 2023
89a4659
fix failing tests
ducaale Jun 18, 2023
f6c6267
testing migration of old cookie format
ducaale Jun 18, 2023
81b7b65
`Date::as_ymd` → `Date::to_calendar_date`
ducaale Jun 18, 2023
2496986
test session cookies from multiple domain
ducaale Jun 18, 2023
d50f94b
update cookie_store and use re-exported RawCookie
ducaale Jun 18, 2023
ac02b56
replace custom cookie splitting with split_parse
ducaale Jun 18, 2023
66320a0
take and return Cookie instead of RawCookie
ducaale Jun 19, 2023
5833cd9
simplify loading cookies into cookie_store
ducaale Jun 24, 2023
3263ee2
store url ref in session
ducaale Jun 24, 2023
08ad9c0
pass cloned url to session
ducaale Jul 16, 2023
73cf504
replace path array with multiple joins
ducaale Aug 6, 2023
159dec7
migrate cookies using localhost.local as domain
ducaale Aug 12, 2023
1551869
fix clippy error
ducaale Aug 12, 2023
b6738cf
Merge branch 'master' into cookies-as-list-in-session
ducaale Aug 16, 2023
1614a44
Merge branch 'master' into cookies-as-list-in-session
ducaale Sep 9, 2023
cc2b406
add context to cookie load errors
ducaale Sep 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 21 additions & 179 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ brotli = { version = "3.3.0", default-features = false, features = ["std"] }
chardetng = "0.1.15"
clap = { version = "4.0", features = ["derive", "wrap_help", "string"] }
clap_complete = { version = "4.0", optional = true }
cookie_crate = { version = "0.15", package = "cookie" }
cookie_store = { version = "0.15.0" }
cookie_store = { version = "0.20.0", features = ["preserve_order"] }
digest_auth = "0.3.0"
dirs = "3.0.1"
encoding_rs = "0.8.28"
Expand All @@ -46,7 +45,7 @@ serde = "1.0"
serde_json = { version = "1.0", features = ["preserve_order"] }
serde_urlencoded = "0.7.0"
termcolor = "1.1.2"
time = "0.2.26"
time = "0.3.16"
unicode-width = "0.1.9"
url = "2.2.2"

Expand Down
2 changes: 1 addition & 1 deletion src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ fn generate_manpages(mut app: clap::Command, rest_args: Vec<String>) -> clap::er
let mut manpage = fs::read_to_string(format!("{}/man-template.roff", rest_args[0])).unwrap();

let current_date = {
let (year, month, day) = DateTime::now_utc().date().as_ymd();
let (year, month, day) = DateTime::now_utc().date().to_calendar_date();
format!("{}-{:02}-{:02}", year, month, day)
};

Expand Down
Loading
Loading