Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add format options: json indentation #318

Merged
merged 1 commit into from
Jul 20, 2023
Merged

add format options: json indentation #318

merged 1 commit into from
Jul 20, 2023

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Jul 17, 2023

closes #316

ducaale
ducaale reviewed Jul 17, 2023
View reviewed changes
src/printer.rs Outdated Show resolved Hide resolved
src/printer.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
src/formatting.rs Outdated Show resolved Hide resolved
src/printer.rs Outdated Show resolved Hide resolved
src/printer.rs Outdated Show resolved Hide resolved
@Bnyro Bnyro force-pushed the format-options branch 2 times, most recently from 7d2f720 to dd8ca0d Compare July 18, 2023 06:43
@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 18, 2023

Thanks for the review though, I'm way more happy with the solution now than I was before!

@Bnyro Bnyro force-pushed the format-options branch 4 times, most recently from 432f880 to bd3a7de Compare July 19, 2023 06:51
ducaale
ducaale reviewed Jul 19, 2023
View reviewed changes
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one more thing left to fix. Other than that, this looks great!

src/cli.rs Outdated Show resolved Hide resolved
@ducaale
Copy link
Owner

ducaale commented Jul 19, 2023

Can you also run cargo fmt to fix the CI error? Thanks

@Bnyro Bnyro changed the title add format options: json indentation, record separator add format options: json indentation Jul 19, 2023
blyxxyz
blyxxyz reviewed Jul 19, 2023
View reviewed changes
src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
blyxxyz
blyxxyz reviewed Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments but it works great, thank you!

src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
ducaale
ducaale reviewed Jul 19, 2023
View reviewed changes
src/cli.rs Outdated Show resolved Hide resolved
blyxxyz
blyxxyz reviewed Jul 19, 2023
View reviewed changes
src/cli.rs Outdated Show resolved Hide resolved
ducaale
ducaale approved these changes Jul 20, 2023
View reviewed changes
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ducaale ducaale merged commit d6bc539 into ducaale:master Jul 20, 2023
8 checks passed
@Bnyro Bnyro deleted the format-options branch July 22, 2023 18:12
@ducaale ducaale mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

@ducaale ducaale ducaale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make JSON indentation level configurable (e.g. 2 or 4 spaces)
3 participants
@Bnyro @ducaale @blyxxyz