Ignore NO_COLOR if set to empty string
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables can have no value at all or they can have the empty string as a value. We used to disable color if `$NO_COLOR` were set at all, regardless of its value, but as of jcs/no_color@99f90e2 we should ignore empty strings (and this makes more sense). Result: `NO_COLOR= xh` now allows colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables can have no value at all or they can have the empty string as a value. We used to disable color if
$NO_COLORwere set at all, regardless of its value, but as of jcs/no_color@99f90e2 we should ignore empty strings (and this makes more sense).Result:
NO_COLOR= xhnow allows colors.