Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply TLS options even for non-HTTPS URLs #372

Merged
merged 1 commit into from
Jun 8, 2024

Commits on Jun 7, 2024

  1. Apply TLS options even for non-HTTPS URLs

    TLS-related options were only being applied for URLs with a `https://`
    scheme. But that's too cautious, because we could run into a HTTPS URL
    after a redirect.
    
    I've fixed this by just removing the check. Another option is to also
    check `args.follow`, but I think it's nicer to do this stuff
    unconditionally. That way we can consistently give errors for bad
    options (e.g. `--verify=path/wiht/typo`).
    
    Test case:
    ```shell
    xh --verify=no --follow http://httpbin.org/redirect-to url==https://expired.badssl.com
    ```
    
    Fixes ducaale#368.
    blyxxyz committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    421e35d View commit details
    Browse the repository at this point in the history