Support profiles that are simply 'type: duckdb' by correctly configuring the in-memory db setup #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the in-memory database in dbt-duckdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to DuckDB 0.7.0, dbt-duckdb could actually work out-of-the-box with no
pathargument at all, since the default value of thepathargument was:memory:and the only database supported was the default of "main". 0.7.0 changed that s.t. if there is nopathsupplied, the value of thedatabasesetting needs to be "memory" for everything to work correctly; this PR updates the code so that the old behavior of running in-memory DBs when the path is unspecified will work correctly in the new regime.