Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings code cleanup after the experiment #2957

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Jun 16, 2024

Task/Issue URL:
https://app.asana.com/0/1148564399326804/1207440329716828/f
https://app.asana.com/0/1148564399326804/1207509504833411/f
https://app.asana.com/0/1148564399326804/1206864291180522/f
https://app.asana.com/0/1148564399326804/1206886662182519/f

Description:
This PR contains a code cleanup after the Settings experiment. It includes:

  • Removal of old Settings code
  • Removal of temporary pixels
  • Removal of Voice Search settings from the Private Search category

Steps to test this PR:

  1. Make sure all new pixels listed in Asana are removed
  2. Make sure Voice Search setting is not present in the Private Search category
  3. Test new Settings screen and make sure all settings work as expected

OS Testing:

  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@tomasstrba tomasstrba requested review from a team, mallexxx and dus7 and removed request for a team and mallexxx June 16, 2024 10:23
Copy link

github-actions bot commented Jun 16, 2024

Fails
🚫 Please, don't forget to add a link to the internal task
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 2e1ef0c

Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to double check. Verified all settings are reachable and work as intended.

Core/PixelEvent.swift Show resolved Hide resolved
@tomasstrba tomasstrba merged commit d1b54d7 into main Jun 21, 2024
13 of 14 checks passed
@tomasstrba tomasstrba deleted the tom/settings-cleanup branch June 21, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants