Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload exception messages to Sentry #2974

Merged
merged 20 commits into from
Jul 12, 2024
Merged

Upload exception messages to Sentry #2974

merged 20 commits into from
Jul 12, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jun 20, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1202406491309510/1207597188072658/f
Tech Design URL: https://app.asana.com/0/1202406491309510/1207311510824180/f
BSK PR: duckduckgo/BrowserServicesKit#856
macOS PR: duckduckgo/macos-browser#2886

Description:

  • unhandled NSException handler
  • unhandled C++ exception saving call stack and message
  • writing sanitized diagnostics to log file
  • uploading diagnostics to Sentry

Steps to test this PR:

  1. Build/Install the app
  2. Launch app (standalone), open Debug menu, simulate NSException crash/C++ exception crash
  3. Launch app from Xcode, validate diagnostic message is loaded and uploaded to Sentry

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx requested a review from bwaresiak June 20, 2024 14:33
This was referenced Jun 20, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jun 29, 2024
@github-actions github-actions bot removed the stale label Jul 2, 2024
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 12, 2024
@mallexxx
Upload exception message to Sentry (#856)
33ceded 
Task/Issue URL: https://app.asana.com/0/1202406491309510/1207597188072658/f
iOS PR: duckduckgo/iOS#2974
macOS PR: duckduckgo/macos-browser#2886
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Jul 12, 2024
@mallexxx
Upload exception message to Sentry (#2886)
c2ad42a 
Task/Issue URL: https://app.asana.com/0/1202406491309510/1207597188072658/f
Tech Design URL: https://app.asana.com/0/1202406491309510/1207311510824180/f
BSK PR: duckduckgo/BrowserServicesKit#856
iOS PR: duckduckgo/iOS#2974
@mallexxx mallexxx merged commit 5c9fc24 into main Jul 12, 2024
14 checks passed
@mallexxx mallexxx deleted the alex/upload-exception-message branch July 12, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mallexxx @bwaresiak