Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copy for autocomplete settings and some minor clean up #2975

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 20, 2024

Task/Issue URL: https://app.asana.com/0/1206767823185684/1207592116853788/f
Tech Design URL:
CC:

Description:
Explicitly call out what recently visited sites toggle does to make it clearer to users so they are less compelled to just disable suggestions entirely. See Copy task

Steps to test this PR:

  1. Edit HistoryMessageManager and set shouldShow to return true
  2. Launch app and start typing in the search field. Message should show with updated copy.
  3. Open settings and go to General. Private Search section should have correct copy for each toggle and no footer
  4. Open settings and go to Private Search. Search Suggestions section should have correct copy for each toggle and no footer

@amddg44 amddg44 self-requested a review June 20, 2024 14:59
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	DuckDuckGo/PrivateSearchView.swift
#	DuckDuckGo/SettingsCustomizeView.swift
#	DuckDuckGo/SettingsGeneralView.swift
@brindy brindy merged commit 83a9d4e into main Jun 24, 2024
14 checks passed
@brindy brindy deleted the brindy/tweak-history-settings-and-copy branch June 24, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants