-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Messaging Framework for macOS #3031
Conversation
surveyActionMapper = DefaultRemoteMessagingSurveyURLBuilder(statisticsStore: statisticsStore, subscription: nil) | ||
} | ||
|
||
let dismissedMessageIds = store.fetchDismissedRemoteMessageIds() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny thing, but I think we once established these acronyms should be all capitalized, so IDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I personally hate that too :D just haven't updated it because it's been like that. Happy do to it since I've moved/updated the entire protocol anyway. Thanks for pointing it out!
Task/Issue URL: https://app.asana.com/0/72649045549333/1202913520695928/f
CC: @amddg44 @samsymons
Description:
This change adjusts RMF implementation to updates in BSK that add support for RMF on macOS.
that is otherwise separated from the RMF client.
for fetching and processing the config. The API is not static and the instance of the client is owned
by AppDelegate.
to have better control over their instantiation time and to allow for dependency injection.
Steps to test this PR:
https://www.jsonblob.com/api/1258315611053613056
for debug builds.Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template