Die when git push fails #3052
Merged
Die when git push fails #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
commented
Jul 5, 2024
| eval git push -u origin "${release_branch}" "$mute" | ||
| if ! eval git push -u origin "${release_branch}" "$mute"; then |
There was a problem hiding this comment.
Tested this with a dummy branch but my bash-fu is quite limited so lmk if there's better way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1207740322700266/f
Tech Design URL:
CC:
Description:
Ran into a silent failure when trying to make a subsequent release for 7.127.0, turned out it was an issue with git push (local branch is behind).
I'm adding a check for git push exit status so it's easier to know what goes wrong.
Also, some extra whitespace removal.
Steps to test this PR:
1.
2.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template