-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add autoclear tests #3056
add autoclear tests #3056
Conversation
@@ -40,6 +40,7 @@ run_flow() { | |||
|
|||
echo "⏲️ Starting flow $( basename $flow)" | |||
|
|||
export MAESTRO_DRIVER_STARTUP_TIMEOUT=60000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents occasional timeouts as maestro does an xcodebuild under the covers in order to build the runner and it can sometimes just crap out.
--rebuild) | ||
rebuild=1 ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support --rebuild
arg so that you can make local changes while running the tests quicker.
if ProcessInfo.processInfo.arguments.contains("autoclear-ui-test") { | ||
return elapsedTime > 5 | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When maestro launches with this argument then all expiries are now 5 seconds. Unit tests and backgrounding UI tests validate that this does not affect production.
@@ -205,6 +205,7 @@ | |||
</label> | |||
<switch opaque="NO" contentMode="scaleToFill" horizontalHuggingPriority="750" verticalHuggingPriority="750" contentHorizontalAlignment="center" contentVerticalAlignment="center" on="YES" translatesAutoresizingMaskIntoConstraints="NO" id="cdQ-74-TuJ"> | |||
<rect key="frame" x="305" y="6.6666666666666679" width="51" height="31.000000000000004"/> | |||
<accessibility key="accessibilityConfiguration" identifier="AutoclearEnabledToggle"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessibility ID to make it more sensible in the UI test.
echo "‼️ Unable to set region" | ||
exit 1 | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brindy I took the liberty to push this change - apparently freshly made simulator defaults to my system locale, failing all tests as a result :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Task/Issue URL: https://app.asana.com/0/392891325557410/1207203028528350/f
Tech Design URL:
CC: @loremattei
Description:
Adds UI tests for autoclearing.
Tweaked storyboard to give the toggle an accessibility ID.
Steps to test this PR:
cd
into.maestro
in the project./setup_ui_tests.sh
run_ui_tests.sh release_tests/autoclear.yaml
run_ui_tests.sh release_tests/backgrounding.yaml