Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desktop specific RMF attributes #3062

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jul 10, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207774753650441/f

Description:
This change bumps BSK to the version containing extra matching attributes that are desktop-only.
There are no functional changes to the iOS app.

Steps to test this PR:
Verify that the CI is green.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy marked this pull request as ready for review July 10, 2024 07:56
@ayoy ayoy requested a review from jaceklyp July 10, 2024 09:03
@ayoy ayoy assigned jaceklyp and unassigned ayoy Jul 10, 2024
@ayoy ayoy merged commit ab0bb3d into main Jul 12, 2024
14 checks passed
@ayoy ayoy deleted the dominik/rmf-desktop-attributes branch July 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants