Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar selection when coming back to the app #3065

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414709148257752/1207736781372157/f
Tech Design URL:
CC:

Description:

Fix Selection when on the serp anc coming back to the app.

Steps to test this PR:

  1. Press fire button.
  2. Ensure the URL bar is selected and keyboard is up.
  3. Leave the app for 6s.
  4. Come back to the app - search for something.
  5. Tap on search bar - text should not be selected, cursor should be at the end.
  6. Hide keyboard, then background the app for 6s.
  7. Come back to the app -> tap on search bar. Whole text should be selected.
  8. Dismiss keyboard, tap on search again. Text should not be selected.
  9. Navigate to non-serp page.
  10. Tap on the url - it should be selected.

Definition of Done (Internal Only):

Device Testing:

  • iPhone
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak requested a review from Bunn July 10, 2024 15:56
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwaresiak bwaresiak merged commit 9b5d747 into main Jul 10, 2024
18 checks passed
@bwaresiak bwaresiak deleted the bartek/fix-search-bar-selection branch July 10, 2024 16:10
Bunn added a commit that referenced this pull request Aug 6, 2024
Task/Issue URL:
https://app.asana.com/0/1204167627774280/1207871109767442/f
Tech Design URL:
CC:

**Description**:
Add UI for displaying Duck Player contingency message
samsymons added a commit that referenced this pull request Aug 7, 2024
# By Mariusz Śpiewak (7) and others
# Via Diego Rey Mendez (1) and GitHub (1)
* main:
  Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166)
  Animate transition between New Tab Page and tab switcher (#3196)
  Fix New Tab Page UI issues on iOS 15 (#3198)
  Push domain exclusions to internal release (#3195)
  Show shortcuts for enabled features only (#3193)
  Translate strings introduced in New Tab Page improvements (#3174)
  Update release workflow to use S3 bucket name from secrets (#3120)
  Handle contingency settings state on remote config (#3190)
  Add UI for displaying Duck Player contingency message #3065 (#3181)
  Open keyboard on New Tab Page based on Settings (#3187)
  Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164)
  Release 7.132.0-0 (#3194)
  Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192)
  Update toolbar items for New Tab Page (#3185)
  new pixel and parameter for monitoring clearing of data stores (#3186)
  ensure new data clearing api is being used (#3191)
  If no App Store subscriptions option are available return empty options object (#3188)
  Show Intro message for existing users on New Tab Page (#3173)
  Experiment Contextual onboarding (#3160)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants