Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale to broken site report #3069

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add locale to broken site report #3069

merged 2 commits into from
Jul 11, 2024

Conversation

SlayterDev
Copy link
Collaborator

@SlayterDev SlayterDev commented Jul 11, 2024

Task/Issue URL: https://app.asana.com/0/1163321984198618/1207751045781572/f
Tech Design URL:
CC:

Description:
See BSK PR

Steps to test this PR:

  1. See BSK PR

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Jul 11, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 11, 2024
@SlayterDev SlayterDev removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 11, 2024
@SlayterDev SlayterDev marked this pull request as ready for review July 11, 2024 14:15
@SlayterDev SlayterDev merged commit ee79a54 into main Jul 11, 2024
14 checks passed
@SlayterDev SlayterDev deleted the brad/broken-site-locale branch July 11, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants