Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Intro Experiment #3074

Merged
merged 18 commits into from
Jul 14, 2024
Merged

Onboarding Intro Experiment #3074

merged 18 commits into from
Jul 14, 2024

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Jul 12, 2024

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207585462837396/f
CC: @SabrinaTardio

Description:

This is the final PR to merge the Onboarding Intro into main. This has been reviewed incrementally. All the code in this PR has already been reviewed

Steps to test this PR:

  1. Smoke test the new Onboarding Intro by
    1.1 Run killall Simulator and run xcrun simctl erase all
  2. Run the App and repeat until the old and new onboarding flows are prompted.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8d7427b

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it a few times and got both onboarding. LGTM, nice work :)

@brindy brindy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 12, 2024
@alessandroboron alessandroboron merged commit 01ebb16 into main Jul 14, 2024
14 checks passed
@alessandroboron alessandroboron deleted the alessandro/onboarding-intro branch July 14, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants