Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused gating logic for history roll out #3075

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jul 12, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207766769947735/f
Tech Design URL:
CC:

Description:
Removes logic related to rolling out history which is now available to everyone.

Steps to test this PR:

  1. Clean install of the app
  2. Perform a search
  3. Visit pages
  4. Type in search bar and confirm history was stored
  5. Use fire button
  6. Confirm history was removed
  7. Disable in settings
  8. Visit pages
  9. Confirm history not added
  10. Enable in settings
  11. Visit pages
  12. Confirm history was stored

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@Bunn Bunn self-requested a review July 12, 2024 13:21
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 3610c70 into main Jul 12, 2024
18 checks passed
@brindy brindy deleted the brindy/remove-history-gating-logic branch July 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants