Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pixel autofillSettingsOpened #3077

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Jul 15, 2024

Task/Issue URL: https://app.asana.com/0/1203822806345703/1207774062910897/f
Tech Design URL:
CC:

Description:
Removes deprecated autofill settings pixel (m_autofill_settings_opened)

Steps to test this PR:

  1. Access the Passwords screen via the Settings screen
  2. Confirm m.autofill.management.opened ["source": "settings”] is fired and that m.autofill.settings.opened is not

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 15, 2024
@amddg44 amddg44 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 15, 2024
@amddg44 amddg44 requested a review from graeme July 15, 2024 10:47
@amddg44 amddg44 merged commit a026767 into main Jul 15, 2024
23 of 24 checks passed
@amddg44 amddg44 deleted the anya/remove-obsolete-autofill-pixel branch July 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants