Add favorites empty state tooltip #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
approved these changes
Jul 26, 2024
samsymons
added a commit
that referenced
this pull request
Jul 26, 2024
# By Dominik Kapusta (2) and others # Via GitHub * main: Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) remove pixels for keyboard toggle (#3135) Keep Remote Messages in database if they were shown (#3136) # Conflicts: # DuckDuckGo/SettingsViewModel.swift
samsymons
added a commit
that referenced
this pull request
Jul 28, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: [DuckPlayer] 13. Add openInfo message to Overlay (#3151) [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147) [DuckPlayer] 11. Tab views and Pixel updates (#3145) Remove the NETWORK_PROTECTION compilation flag (#3139) Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) remove pixels for keyboard toggle (#3135) Keep Remote Messages in database if they were shown (#3136) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 31, 2024
# By Dominik Kapusta (3) and others # Via GitHub * main: New Tab Page Settings (#3140) New Tab Page Settings Storage (#3159) Prevent endless rekey and tunnel update cycle (#3091) tentatively fix content blocking UI test (#3141) Update Autofill UI test to reflect updated app copy (#3158) Duck player support on RMF (#3146) Release 7.131.0-0 (#3157) Update BSK with autofill 12.1.0 (#3155) Report Autofill issues via Passwords screen (#3116) Update GRDB to 2.4.0 (upstream 6.29.0, SQLCipher 4.6.0) (#3153) Update fastlane to 2.222.0 (#3154) [DuckPlayer] 13. Add openInfo message to Overlay (#3151) [DuckPlayer] 12. Ensure DuckPlayer does not leak without the proper config (#3147) [DuckPlayer] 11. Tab views and Pixel updates (#3145) Remove the NETWORK_PROTECTION compilation flag (#3139) Add favorites empty state tooltip (#3119) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3113) iOS 14 deprecation cleanup (#3098) Update Xcode version to 15.4 (#3142) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1207871220127307/f
Tech Design URL:
CC:
Description:
Adds a tooltip for empty Favorites state with information on how to add favorites.
Steps to test this PR:
-- Enable NTP Sections in debug menu --
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template