Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm ui issue #145 #151

Merged
merged 50 commits into from
Dec 18, 2019
Merged

Elm ui issue #145 #151

merged 50 commits into from
Dec 18, 2019

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Dec 10, 2019 •
edited
Loading

Hi @SimonLab & @iteles I've written a quick intro (tutorial) for elm-ui
It starts from scratch and goes into a bit more depth than other elm-ui tutorials I've seen.

To review/read it, see: https://github.com/dwyl/learn-elm/tree/elm-ui-issue%23145/tutorials/elm-ui

@nelsonic
add link to "Building a Toolkit for Design" by Matthew Griffith video h…
fd932d6 
…ttps://youtu.be/Ie-gqwSHQr0 #145
@nelsonic
re-org "Why Not" to end of page
e76afbb
@nelsonic
add examples of errors for elm-ui "What?" section #145
1ed0390
@nelsonic
add sample code for elm-ui #145
aef3a97
@nelsonic
add instructions for converting hex to rgb (required for elm-ui) #145
fd978f4
@nelsonic
add more examples of compilation errors typo: paddign > padding #145
03023b2
@nelsonic
suggest an alternative scoped import to reduce line length for elm-ui #…
d754300 
…145
@nelsonic
update example of scoped import for elm-ui example/tutorial #145
31065a1
@nelsonic
must return to view width example after constructing sample App layout
c372a1e
@nelsonic
add padding and background to row element in elm-ui tutorial #145
856c68c
@nelsonic
comment out nav example in elm-ui #145
8440a1f
@nelsonic
add explanation of main function requirement in elm programs with scr…
c836e28 
…eenshots
@nelsonic
add explanation of row for #145
01ede3b
@nelsonic
finished explaining the basic elm-ui example line-by-line for #145
79717bd
@nelsonic
clarify explanation of el function in elm-ui #145
a47ebcb
@nelsonic
update link to Ellie example for people who cant install #145
7dbaf66
@nelsonic
update intro copy in "Why?" section of elm-ui #145
89a21e7
@nelsonic
re-org elm-ui/README.md intro
5a058f0
@nelsonic
add section using Element.explain Debug.todo to debug layout #145
32d83bb
@nelsonic
add additional sub-heading for easier navigation
45cfc39
@nelsonic
deep link to modules section of elm guide https://guide.elm-lang.org/…
f323c8b 
…webapps/modules.html
iteles
iteles requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @nelsonic 🙌 Saved me loads of time.

I've added some proposed changes with one or two being typos that are worth quickly sorting before we publish 😊

tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Outdated Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
tutorials/elm-ui/README.md Outdated Show resolved Hide resolved
tutorials/elm-ui/README.md Outdated Show resolved Hide resolved
tutorials/elm-ui/README.md Show resolved Hide resolved
@iteles iteles assigned nelsonic and unassigned iteles and SimonLab Dec 18, 2019
nelsonic and others added 13 commits December 18, 2019 16:00
@nelsonic @iteles
remove hyphen from spelling of "side effects" even though the spellin…
4a2db2b 
…g is valid. https://english.stackexchange.com/questions/364613/side-effects

Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix typo "over-time" > "over time"
e26de89 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
add clarifying words to "categorising" sentence.
6465a1d 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix grammar in sentence "this tedious" > "this is tedious"
90f0c2e 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
re-word sentence for clarity
ad9b84a 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
elm init will *prompt* the user for permission to create an elm.json …
3996327 
…file.

Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
remove line of copy
aa1bc3e 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix typo "changes" > "chances" :+!:
fe1b35f 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix markdown error (closing italic)
55defd2 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix typo myElelement > myElement
8634dc1 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
add full stop to end of sentence.
e2836ec 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
fix grammar
7fdcef7 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic @iteles
add "and" to sentence to fix grammar
5f2331d 
Co-Authored-By: Ines Teles Correia <[email protected]>
@nelsonic
Copy link
Member Author

@iteles all your typos fixes and grammar corrections have been committed. 👍
Thanks.

@nelsonic nelsonic assigned iteles and unassigned nelsonic Dec 18, 2019
iteles
iteles approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this excellent tutorial @nelsonic

@iteles iteles merged commit 757e419 into master Dec 18, 2019
@iteles iteles deleted the elm-ui-issue#145 branch December 18, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab left review comments

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
awaiting-review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nelsonic @iteles @SimonLab