Responsive Nav Menu Example issue #10 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iteles
approved these changes
Jan 31, 2020
| relies on [Isabel Castillo](https://github.com/isabelc)'s | ||
| brilliant _hidden_ `checkbox` idea: | ||
| https://isabelcastillo.com/pure-css-mobile-toggle-menu | ||
| (shared by @iteles in |
There was a problem hiding this comment.
Haha I didn't need the shout-out but thank you!
There was a problem hiding this comment.
you found the pearl. definitely worth recognising. recognition is core to our culture. ❤️
Co-Authored-By: Ines Teles Correia <[email protected]>
Co-Authored-By: Ines Teles Correia <[email protected]>
SimonLab
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the
start|stop timerfeature dwyl/app#265,I tried to implement a mobile-first (responsive) navigation menu in Tachyons and failed miserably. 🤦♂
After some googling I discovered issue #10 (which I had opened a while back ...)
(It's always good to re-discover a @dwyl issue with some helpful content! the system works!!)
@Cleop left a comment #10 (comment) linking to the
dwyl-siteimplementation of the CSS-only responsive navigation menu: https://github.com/dwyl/dwyl-site/pull/264/files#diff-b0638442d6af953ff33fca3d49113579L18The link and brief explanation is much better than nothing, so thanks for the comment! 🥇
And judging by how much ❤️ the comment has received from the community:
A lot of people using Tachyons have found this useful. 🎉
But ... rather than forcing people to read through a commit which isn't very beginner-friendly,
I've split out the code and simplified it into an example with in-line comments and explanation.
This PR includes
README.md: https://github.com/dwyl/learn-tachyons/tree/responsive-nav-menu-issue%2310#responsive-navigation-menuexamples/nav-menu.htmlfile people can learn from and play with.@iteles / @SimonLab please take a look when you can. (not urgent, just nice-to-have)
Thanks! 🌻