Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: reimplement PermissionsEditor tests #1756

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 28, 2024

closes #1684

Copy link
Owner Author

dyc3 commented Apr 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

@dyc3 dyc3 marked this pull request as ready for review April 28, 2024 19:41
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.8183%. Comparing base (e581552) to head (2656ade).

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1756        +/-   ##
================================================
+ Coverage   62.8078%   62.8183%   +0.0104%     
================================================
  Files           168        168                
  Lines         24852      24859         +7     
  Branches       1444       1444                
================================================
+ Hits          15609      15616         +7     
  Misses         9190       9190                
  Partials         53         53                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 merged commit 73e2d0f into master Apr 28, 2024
23 checks passed
@dyc3 dyc3 deleted the 04-28-tests_reimplement_permissionseditor_tests branch April 28, 2024 19:44
Copy link

cypress bot commented Apr 28, 2024

Passing run #1897 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge 2656ade into e581552...
Project: OpenTogetherTube Commit: 9fdfa8354c ℹ️
Status: Passed Duration: 04:57 💡
Started: Apr 28, 2024 7:40 PM Ended: Apr 28, 2024 7:45 PM

Review all test suite changes for PR #1756 ↗︎

Copy link

cypress bot commented Apr 28, 2024

Passing run #1898 ↗︎

0 84 1 0 Flakiness 0

Details:

tests: reimplement `PermissionsEditor` tests (#1756)
Project: OpenTogetherTube Commit: 73e2d0f3cc
Status: Passed Duration: 04:54 💡
Started: Apr 28, 2024 7:45 PM Ended: Apr 28, 2024 7:50 PM

Review all test suite changes for PR #1756 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite lost unit tests for PermissionsEditor as cypress component tests
1 participant