Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: visually simplify create room form #1757

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 29, 2024

No description provided.

Copy link
Owner Author

dyc3 commented Apr 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

@dyc3 dyc3 marked this pull request as ready for review April 29, 2024 12:49
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 62.7905%. Comparing base (73e2d0f) to head (e5c79fe).

Files Patch % Lines
client/src/components/CreateRoomForm.vue 0.0000% 45 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1757        +/-   ##
================================================
- Coverage   62.8183%   62.7905%   -0.0278%     
================================================
  Files           168        168                
  Lines         24859      24870        +11     
  Branches       1444       1444                
================================================
  Hits          15616      15616                
- Misses         9190       9201        +11     
  Partials         53         53                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 29, 2024

Passing run #1899 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge e5c79fe into 73e2d0f...
Project: OpenTogetherTube Commit: 2fb49d2953 ℹ️
Status: Passed Duration: 04:52 💡
Started: Apr 29, 2024 12:48 PM Ended: Apr 29, 2024 12:53 PM

Review all test suite changes for PR #1757 ↗︎

@dyc3 dyc3 merged commit fdb829a into master Apr 29, 2024
22 of 23 checks passed
@dyc3 dyc3 deleted the 04-29-client_visually_simplify_create_room_form branch April 29, 2024 13:14
Copy link

cypress bot commented Apr 29, 2024

Passing run #1900 ↗︎

0 84 1 0 Flakiness 0

Details:

client: visually simplify create room form (#1757)
Project: OpenTogetherTube Commit: fdb829a482
Status: Passed Duration: 05:12 💡
Started: Apr 29, 2024 1:15 PM Ended: Apr 29, 2024 1:20 PM

Review all test suite changes for PR #1757 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant