Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer: HashRing: repeat nodes on ring to balance better #1758

Merged

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Apr 29, 2024

No description provided.

Copy link
Owner Author

dyc3 commented Apr 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

@dyc3 dyc3 force-pushed the 04-29-balancer_hashring_repeat_nodes_on_ring_to_balance_better branch from 46cab93 to 0754ead Compare April 29, 2024 13:57
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7905%. Comparing base (fdb829a) to head (0754ead).

❗ Current head 0754ead differs from pull request most recent head ccfdb1a. Consider uploading reports for the commit ccfdb1a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1758   +/-   ##
===========================================
  Coverage   62.7905%   62.7905%           
===========================================
  Files           168        168           
  Lines         24870      24870           
  Branches       1444       1445    +1     
===========================================
  Hits          15616      15616           
  Misses         9201       9201           
  Partials         53         53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 29, 2024

Passing run #1905 ↗︎

0 27 0 0 Flakiness 0

Details:

Merge ccfdb1a into fdb829a...
Project: OpenTogetherTube Commit: a26bf10408 ℹ️
Status: Passed Duration: 03:50 💡
Started: Apr 29, 2024 2:24 PM Ended: Apr 29, 2024 2:28 PM

Review all test suite changes for PR #1758 ↗︎

@dyc3 dyc3 marked this pull request as ready for review April 29, 2024 14:11
@dyc3 dyc3 force-pushed the 04-29-balancer_hashring_repeat_nodes_on_ring_to_balance_better branch from 0754ead to ccfdb1a Compare April 29, 2024 14:18
@dyc3 dyc3 merged commit aa795a2 into master Apr 29, 2024
29 of 34 checks passed
@dyc3 dyc3 deleted the 04-29-balancer_hashring_repeat_nodes_on_ring_to_balance_better branch April 29, 2024 14:22
Copy link

cypress bot commented Apr 29, 2024

Passing run #1904 ↗︎

0 84 1 0 Flakiness 0

Details:

balancer: HashRing: repeat nodes on ring to balance better (#1758)
Project: OpenTogetherTube Commit: aa795a2619
Status: Passed Duration: 04:31 💡
Started: Apr 29, 2024 2:23 PM Ended: Apr 29, 2024 2:28 PM

Review all test suite changes for PR #1758 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant