Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove material-design-icons-iconfont #1769

Merged
merged 1 commit into from
May 1, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented May 1, 2024

No description provided.

Copy link
Owner Author

dyc3 commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented May 1, 2024

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-05-01 01:36:04.000094259 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-05-01 01:36:04.164095753 +0000
@@ -30,7 +30,7 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js                        �[39m�[1m�[2m    0.34 kB�[22m�[1m�[22m�[2m │ gzip:   0.26 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js                           �[39m�[1m�[2m    0.60 kB�[22m�[1m�[22m�[2m │ gzip:   0.32 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js                        �[39m�[1m�[2m    1.04 kB�[22m�[1m�[22m�[2m │ gzip:   0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.95 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js                           �[39m�[1m�[2m    2.31 kB�[22m�[1m�[22m�[2m │ gzip:   1.08 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js                            �[39m�[1m�[2m    2.64 kB�[22m�[1m�[22m�[2m │ gzip:   1.29 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
@@ -45,4 +45,4 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 25.52s�[39m
+�[32m✓ built in 25.73s�[39m

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.8452%. Comparing base (df311e3) to head (5c14fda).

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1769   +/-   ##
===========================================
  Coverage   62.8452%   62.8452%           
===========================================
  Files           168        168           
  Lines         24912      24912           
  Branches       1444       1444           
===========================================
  Hits          15656      15656           
  Misses         9203       9203           
  Partials         53         53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 marked this pull request as ready for review May 1, 2024 01:38
Copy link

cypress bot commented May 1, 2024

Passing run #1970 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge 5c14fda into df311e3...
Project: OpenTogetherTube Commit: bfe30fc672 ℹ️
Status: Passed Duration: 05:16 💡
Started: May 1, 2024 1:35 AM Ended: May 1, 2024 1:40 AM

Review all test suite changes for PR #1769 ↗︎

@dyc3 dyc3 merged commit eaa058a into master May 1, 2024
26 checks passed
@dyc3 dyc3 deleted the 04-30-deps_remove_material-design-icons-iconfont_ branch May 1, 2024 01:48
Copy link

cypress bot commented May 1, 2024

Passing run #1973 ↗︎

0 84 1 0 Flakiness 0

Details:

deps: remove `material-design-icons-iconfont` (#1769)
Project: OpenTogetherTube Commit: eaa058a227
Status: Passed Duration: 04:33 💡
Started: May 1, 2024 1:50 AM Ended: May 1, 2024 1:54 AM

Review all test suite changes for PR #1769 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant