Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for Brazilian Portuguese (pt-br) #1785

Merged
merged 5 commits into from
Jul 14, 2024
Merged

Conversation

Kahlis
Copy link
Contributor

@Kahlis Kahlis commented Jul 12, 2024

This pull request introduces a new locale file and option in locale menu for Brazilian Portuguese (pt-br). I took the liberty of not only translating but also localizing some expressions to make it more appealing to the Brazilian audience.

Files Modified:

(new) client/src/locales/pt-br.ts
(updated) client/src/components/navbar/LocaleSelector.vue

Tested with some friends.

@Kahlis Kahlis requested a review from dyc3 as a code owner July 12, 2024 03:57
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 411 lines in your changes missing coverage. Please review.

Project coverage is 61.6161%. Comparing base (c91bbab) to head (c0f8e31).

Files Patch % Lines
client/src/locales/pt-br.ts 0.0000% 406 Missing and 1 partial ⚠️
client/src/components/navbar/LocaleSelector.vue 0.0000% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1785        +/-   ##
================================================
- Coverage   62.6278%   61.6161%   -1.0117%     
================================================
  Files           168        169         +1     
  Lines         25032      25443       +411     
  Branches       1446       1447         +1     
================================================
  Hits          15677      15677                
- Misses         9302       9712       +410     
- Partials         53         54         +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3
Copy link
Owner

dyc3 commented Jul 12, 2024

Thanks! Just fix the formatting with yarn format and this will be good to merge

@Kahlis
Copy link
Contributor Author

Kahlis commented Jul 12, 2024

Sure, I will make the changes and commit. In my future contribuitions I'll remember to do that before PR. Thank you!

@Kahlis
Copy link
Contributor Author

Kahlis commented Jul 14, 2024

Yarn format is not a script in package-json, so I used yarn lint that probably is what you meant. Also made some casing corrections that I thought was necessary.

@dyc3
Copy link
Owner

dyc3 commented Jul 14, 2024

Yup, thats what i meant.

@dyc3 dyc3 merged commit 3f6ebc2 into dyc3:master Jul 14, 2024
22 of 24 checks passed
Copy link

cypress bot commented Jul 14, 2024

Passing run #1990 ↗︎

0 84 1 0 Flakiness 0

Details:

Localization for Brazilian Portuguese (pt-br) (#1785)
Project: OpenTogetherTube Commit: 3f6ebc21da
Status: Passed Duration: 05:06 💡
Started: Jul 14, 2024 11:27 AM Ended: Jul 14, 2024 11:32 AM

Review all test suite changes for PR #1785 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants