Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF2pp accleration with create_buses #2118

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Conversation

mfisch42
Copy link
Contributor

No description provided.

@rbolgaryn
Copy link
Member

Hi @mfisch42 ,

this repeats the pull request #2117. Is there a reason for it?

@KS-HTK KS-HTK added stale No furter development for more than six month question Further information is requested labels May 14, 2024
# Conflicts:
#	pandapower/converter/powerfactory/pp_import_functions.py
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 224 lines in your changes missing coverage. Please review.

Project coverage is 77.45%. Comparing base (00d9e22) to head (c894c1e).

Files Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 4.31% 222 Missing ⚠️
pandapower/create.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2118      +/-   ##
===========================================
- Coverage    77.58%   77.45%   -0.13%     
===========================================
  Files          278      278              
  Lines        31143    31206      +63     
===========================================
+ Hits         24162    24171       +9     
- Misses        6981     7035      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawellytaev
Copy link
Contributor

Tests are running through but I guess this is due to the low test coverage of PF2pp converter. we need to discuss before merging

@pawellytaev pawellytaev marked this pull request as draft July 8, 2024 06:49
@pawellytaev pawellytaev changed the title Alex dev PF2pp accleration with create_buses Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale No furter development for more than six month
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants