-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/branch parallel to substation #2178
Open
SteffenMeinecke
wants to merge
8
commits into
e2nIEE:develop
Choose a base branch
from
SteffenMeinecke:feature/branch_parallel_to_substation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/branch parallel to substation #2178
SteffenMeinecke
wants to merge
8
commits into
e2nIEE:develop
from
SteffenMeinecke:feature/branch_parallel_to_substation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SteffenMeinecke
commented
Nov 23, 2023
- is based on add tollbox function get_substations that finds clusters of connected… #2177 and [ADDED] toolbox functions #2176
- it can be discussed whether branches_parallel_to_bus_bus_switches() and check_parallel_branch_to_bus_bus_switch() are still needed and if not whether branches_parallel_to_bus_bus_switch_clusters() should be renamed
…_bus_switches(), check_parallel_branch_to_bus_bus_switch()
…/SteffenMeinecke/pandapower into feature/branch_parallel_to_bb_sw
… buses (ignoring branches except for tranaformers) and say they are substations
…andapower into feature/branch_parallel_to_substation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2178 +/- ##
===========================================
+ Coverage 79.65% 79.67% +0.02%
===========================================
Files 255 255
Lines 27795 27853 +58
===========================================
+ Hits 22139 22193 +54
- Misses 5656 5660 +4 ☔ View full report in Codecov by Sentry. |
this PR can be closed if more advanced code on substations are provided by @ascheidl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.