[feature] timeseries: Enable saving of compressed CSV files #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @jokabrink this is a nice feature! Please add a minimal test for this feature in pandapower/test/timeseries/test_output_writer.py and mention the change in the CHANGELOG file. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2209 +/- ##
============================================
+ Coverage 62.30% 79.43% +17.13%
============================================
Files 255 255
Lines 28062 27953 -109
============================================
+ Hits 17483 22205 +4722
+ Misses 10579 5748 -4831 ☔ View full report in Codecov by Sentry. |
Check if "csv" is between two dots instead of full match to enable compression by Pandas.
vogt31337
force-pushed
the
feature/compressed-csv
branch
from
ca9e3cc
to
2afbe2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the
OutputWriter()object, passingoutput_file_type=".csv.zip"should not result in a warning or error, but instead tell Pandas to save the data using the inferred compression format. This is possible because the documentation in https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.to_csv.html allows for inferred compression types from file name.