Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent controller parameters and avoiding misunderstanding of group column names #2334

Merged
merged 22 commits into from
Aug 14, 2024

Conversation

SteffenMeinecke
Copy link
Member

@SteffenMeinecke SteffenMeinecke commented Jul 8, 2024

on top of that:

improved consideration of controllers in get_equivalent()
p_profile and q_profile usage fix in DERController

alternative (uncomlete renaming) to #2332

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.89796% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (8502b3e) to head (082a230).

Files Patch % Lines
pandapower/convert_format.py 88.46% 3 Missing ⚠️
pandapower/control/util/diagnostic.py 84.61% 2 Missing ⚠️
pandapower/toolbox/grid_modification.py 93.93% 2 Missing ⚠️
...er/control/controller/DERController/der_control.py 87.50% 1 Missing ⚠️
pandapower/control/controller/trafo_control.py 96.66% 1 Missing ⚠️
...pp/converter_classes/transformers/tapController.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2334      +/-   ##
===========================================
+ Coverage    76.38%   76.40%   +0.01%     
===========================================
  Files          280      280              
  Lines        32407    32427      +20     
===========================================
+ Hits         24755    24776      +21     
+ Misses        7652     7651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jwiemer112 jwiemer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the implementation :-)

@jwiemer112 jwiemer112 merged commit 57c60a1 into e2nIEE:develop Aug 14, 2024
18 of 28 checks passed
@SteffenMeinecke SteffenMeinecke deleted the feature/rename_tid branch August 15, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants