Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pf2pp: reactive and active power limits of gen and sgens will be converted #2359

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mfisch42
Copy link
Contributor

active and reactive power limits of sgens and gens of pf will be converted to pp

@pawellytaev pawellytaev self-requested a review July 30, 2024 13:18
@mfisch42 mfisch42 marked this pull request as ready for review August 2, 2024 11:54
SteffenMeinecke
SteffenMeinecke previously approved these changes Aug 6, 2024
Copy link
Member

@SteffenMeinecke SteffenMeinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check that the changes work but it seems good. Thanks :)

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.97%. Comparing base (11af12c) to head (9577547).

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2359      +/-   ##
===========================================
- Coverage    76.00%   75.97%   -0.04%     
===========================================
  Files          282      282              
  Lines        32950    32964      +14     
===========================================
  Hits         25045    25045              
- Misses        7905     7919      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants