match changes in https://github.com/flipkart-incubator/zjsonpatch/rel…

…eases/tag/0.4.3 specifically, fix flipkart-incubator/zjsonpatch#66
eBay · Mar 6, 2018 · 88249b4 · 88249b4
1 parent 8bc75b6
commit 88249b4
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -20,15 +20,15 @@ The code here was ported (copied, renamed, repackaged, modified) from the [zjson
 
 ### How to use:
 
-### Current Version : 0.4.2
+### Current Version : 0.4.3
 
 Add following to `<dependencies/>` section of your pom.xml -
 
 ```xml
 <dependency>
   <groupId>com.ebay.bsonpatch</groupId>
   <artifactId>bsonpatch</artifactId>
-  <version>0.4.2</version>
+  <version>0.4.3</version>
 </dependency>
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
 	<groupId>com.ebay.bsonpatch</groupId>
 	<artifactId>bsonpatch</artifactId>
-	<version>0.4.2-SNAPSHOT</version>
+	<version>0.4.3</version>
 	<packaging>jar</packaging>
 
 	<name>${project.groupId}:${project.artifactId}</name>

diff --git a/src/main/java/com/ebay/bsonpatch/InPlaceApplyProcessor.java b/src/main/java/com/ebay/bsonpatch/InPlaceApplyProcessor.java
@@ -152,9 +152,9 @@ public void replace(List<String> path, BsonValue value) {
             String fieldToReplace = path.get(path.size() - 1).replaceAll("\"", "");
             if (isNullOrEmpty(fieldToReplace) && path.size() == 1)	
                 target = value;
-            else if (parentNode.isDocument())
+            else if (parentNode.isDocument() && parentNode.asDocument().containsKey(fieldToReplace)) {
                 parentNode.asDocument().put(fieldToReplace, value);
-            else if (parentNode.isArray())
+            } else if (parentNode.isArray())
                 parentNode.asArray().set(arrayIndex(fieldToReplace, parentNode.asArray().size() - 1, false), value);
             else
                 error(Operation.REPLACE, "noSuchPath in source, path provided : " + PathUtils.getPathRepresentation(path));

diff --git a/src/test/resources/testdata/replace.json b/src/test/resources/testdata/replace.json
@@ -9,6 +9,12 @@
         {
             "op": [{ "op": "replace", "path": "/x/y", "value": false }],
             "node": { "x": "a" }
+        },
+        {
+            "op": [{ "op": "replace", "path": "non-existing-path", "value": "some-value"}],
+            "node": { },
+            "type": "BsonPatchApplicationException",
+            "message": "noSuchPath in source"
         }
     ],
     "ops": [