-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date-textbox): localize date placeholders #2191
Conversation
🦋 Changeset detectedLatest commit: 6b318c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good
Will verify it locally
.changeset/hot-maps-refuse.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"@ebay/ebayui-core": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be major
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is actually because 14.0.0
does not match with master
, I didn't add a changeset
scripts/generate-date-info.js
Outdated
}; | ||
|
||
const modernLocales = JSON.parse( | ||
fs.readFileSync("node_modules/cldr-core/availableLocales.json"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do a json top level import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, that's more clean for sure. Added.
…alized-date-placeholders
Description
date-textbox
andcalendar
Screenshots