Ensure new timezone names end in '>' #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce code slightly and ensure that only names of the form '<...>' including the terminal '>' are accepted in the parser. Fixes a potential error handling corner case.
earlephilhower
added a commit
to earlephilhower/Arduino
that referenced
this pull request
Nov 12, 2020
earlephilhower/newlib-xtensa#15 Removed a couple lines of code and ensures that only TZs of the <..> form are accepted (i.e. ensure the terminal '>').
earlephilhower
added a commit
to esp8266/Arduino
that referenced
this pull request
Nov 12, 2020
Undoes the change in #7699 and fixed #7690 root cause. Newlib did not support timezone names of the form "<[+-]?[0-9]+>" and would parse the offset using the <name>. Fix newlib tzset parser with earlephilhower/newlib-xtensa#14 earlephilhower/newlib-xtensa#15 and undo the UNK changes used as an expedient workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce code slightly and ensure that only names of the form '<...>'
including the terminal '>' are accepted in the parser. Fixes a
potential error handling corner case.