Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-aligned PSTR() #7

Closed
wants to merge 1 commit into from
Closed

Allow non-aligned PSTR() #7

wants to merge 1 commit into from

Conversation

s-hadinger
Copy link

Report PR esp8266/Arduino#7275

Reporting the code from Arduino repo, also changed __pstr__ to __c. Is this change ok?

earlephilhower
earlephilhower requested changes May 7, 2020
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please undo the __pstr__->__c change? We're using that name in GCC 9 to make the link easier.

@s-hadinger s-hadinger closed this May 7, 2020
@s-hadinger
Copy link
Author

Sure, I created a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-hadinger @earlephilhower