-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom file name for file download #891
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 93.91% 93.01% -0.90%
==========================================
Files 26 26
Lines 1708 1746 +38
==========================================
+ Hits 1604 1624 +20
- Misses 104 122 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@eculler if you can check this out and see if it does what you expect it too that would be appreciated! |
This looks good to me! I will try running it with one of our NCEI downloads, too. |
@eculler let me know the results of that! |
Ok @nkorinek , so this looks like the design is what I was looking for, but currently the http parameters remain in the filename (the base file name is what I specified.):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature isn't working quite right - it still tacks on http parameters to the file name. See my comment on the Conversation thread.
Added the argument
file_name
that can be used with custom url downloads inearthpy.data.get_data()
. Allows users to change the name of the final file downloaded. Can't be used withkey
downloads.