Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamespaceId, SubspaceId, PayloadDigest, IsAuthorisedWrite, Entry, AuthorisedEntry #16

Merged
merged 11 commits into from
Jun 23, 2024

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Jun 19, 2024

  • Added NamespaceId trait
  • Added SubspaceId trait
  • Added PayloadDigest trait
  • Entry is just a struct, rather than a trait.
    • Just uses normal generics rather than const generics, as these are constrained to a few types.
  • AuthorisedEntry is a struct too.
    • There is no PossiblyAuthorisedEntry.
    • AuthorisedEntry::new uses the IsAuthorisedWrite trait (implementing Fn) to determine whether it should return an error or not.

@sgwilym sgwilym added the enhancement New feature or request label Jun 19, 2024
Base automatically changed from path-doc to path-base June 19, 2024 15:06
Base automatically changed from path-base to main June 19, 2024 16:23
@sgwilym sgwilym changed the title [WIP] First pass on Entry + AuthorisedEntry NamespaceId, SubspaceId, PayloadDigest, IsAuthorisedWrite, Entry, AuthorisedEntry Jun 20, 2024
@sgwilym sgwilym marked this pull request as draft June 20, 2024 07:57
@sgwilym sgwilym marked this pull request as ready for review June 21, 2024 12:36
@sgwilym sgwilym merged commit d547db7 into main Jun 23, 2024
1 check passed
@sgwilym sgwilym deleted the entry branch June 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants