-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting rid of aliases for selection functions #265
Comments
I thought the rational was that all |
Okay, that sounds reasonable to me.
Maybe, but it's also more confusing. But I still think The fewer functions we have that the user needs to learn, the lower the cognitive load we are imposing on them. Users are also likely to find it more familiar to work with. |
find_/get_columns was indeed related to insight's logic, but I also agree that moving forward we should actually start deprecating and pruning aliases and focus on "the most easystatsy way" of doing things |
Yeah, I like |
agree. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
* easystats/easystats#404 * update snapshots * lintr, comments * fix demean() * fix means_by_group * fix * update news * fix rescale_weights * silence tests * Update NEWS.md Co-authored-by: Etienne Bacher <[email protected]> * deprecation warnings * use insight remotes * Update NEWS.md Co-authored-by: Etienne Bacher <[email protected]> * Also address #265 * update docs * update docs and tests * Update extract_column_names.R * update readme * trigger CI * revert commits related to aliases * version * news * other remnants * fix * do not use devel pkgdown * lintr * same --------- Co-authored-by: Etienne Bacher <[email protected]>
* Also address #265 * update docs * update docs and tests * Update extract_column_names.R * update readme * trigger CI * fix * do not remove find_columns yet * fix news * lintr, styler * fix * lintr * add favicons to work around pkgdown bug --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Indrajeet Patil <[email protected]>
get_columns()
is confusing because, unless you read the docs, it is not clear whether the function returns column names, or a list of vectors, or a data frame.data_select()
is much better, since we have established thatdata_*()
functions always return a data frame. Keeping theget_columns()
around for long is inviting confusion.The same is true for
data_find()
. All otherdata_*()
functions return data frames, while this one returns an atomic vector. This messes user's mental model. We should remove it in favour offind_columns()
.Created on 2022-09-14 with reprex v2.0.2
This is probably something we can do in
0.7
or later.The text was updated successfully, but these errors were encountered: