Make it faster #106
Open
Make it faster #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor to use httpx instead of Requests/Niquests * Fix video.py and hls.py handling of M3U8 manifests * Fix bug in hls.variant_streams()
ebb-earl-co
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tidal_wave/video.py
Outdated
| self.M3U8 = m3u8.load(playlist.uri) | ||
| if self.M3U8 is None or len(self.M3U8.files) == 0: | ||
| m3u8_files: List[str] = variant_streams(self.m3u8, client, return_urls=True) | ||
| if not all(file.startswith("http://vmz-ad-cf.video.tidal.com") for file in m3u8_files): |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to change the fundamental library of the project,
requests, to something faster, addressing #97