Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Issue, Restrict to Python < 3.13, and Allow 2-Digit TIDAL IDs #188

Merged
merged 69 commits into from
Jul 20, 2024
Merged

Address Issue, Restrict to Python < 3.13, and Allow 2-Digit TIDAL IDs #188

merged 69 commits into from
Jul 20, 2024

Conversation

ebb-earl-co
Copy link
Owner

This pull request brings in a few changes:

  • bump versions of Python package dependencies
  • address (and, hopefully, solve) issue Better folder name sanitization needed #186
  • Expand the allowed URLs for albums and artists: 2-digit identifiers are valid, such as artist 53 is Neil Diamond
  • Include a --version flag for CLI to report current version of tidal-wave

dependabot bot and others added 30 commits April 9, 2024 07:06
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump typer (#151)
a44ad69 
Bumps [typer](https://github.com/tiangolo/typer) from 0.12.1 to 0.12.2.
- [Release notes](https://github.com/tiangolo/typer/releases)
- [Changelog](https://github.com/tiangolo/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.12.1...0.12.2)

---
updated-dependencies:
- dependency-name: typer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump typer (#152)
9426bcc 
Bumps [typer](https://github.com/tiangolo/typer) from 0.12.2 to 0.12.3.
- [Release notes](https://github.com/tiangolo/typer/releases)
- [Changelog](https://github.com/tiangolo/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.12.2...0.12.3)

---
updated-dependencies:
- dependency-name: typer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Put back 'macOS [m]' in login.py prompt
89b8191
@ebb-earl-co @dependabot
Merge upstream branch, trunk, into develop (#150)
4633dc5 
* Bump Dependence Version and Re-add User Prompt Option (#153)

* Dependabot monitoring PyPi dependencies(deps): Bump typer (#151)

Bumps [typer](https://github.com/tiangolo/typer) from 0.12.1 to 0.12.2.
- [Release notes](https://github.com/tiangolo/typer/releases)
- [Changelog](https://github.com/tiangolo/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.12.1...0.12.2)

---
updated-dependencies:
- dependency-name: typer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Dependabot monitoring PyPi dependencies(deps): Bump typer (#152)

Bumps [typer](https://github.com/tiangolo/typer) from 0.12.2 to 0.12.3.
- [Release notes](https://github.com/tiangolo/typer/releases)
- [Changelog](https://github.com/tiangolo/typer/blob/master/docs/release-notes.md)
- [Commits](fastapi/typer@0.12.2...0.12.3)

---
updated-dependencies:
- dependency-name: typer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Put back 'macOS [m]' in login.py prompt

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Add BUILDME.md to pyinstaller binaries
e22d0c5
@ebb-earl-co
More than 100 items (#156)
ee1185e 
* Revamp tidal_wave/playlist.py to handle > 100 items

* Revamp mix.py to handle paginated API responses

* Add logic for 'transparent' flag to mix.py

* Revamp album.Album.set_tracks() for albums with more than 100 tracks

* Add in playlist.request_playlist_items() the logic for 'transparent' flag

* Remove from playlist.flatten_playlist_dir() a duplicate "subdirs: Set[Path] = set()"

* Fix reference to `TidalPlaylistException` in mix.py
@ebb-earl-co
Update README.md
945d8b3 
Fix the instructions for long-running docker container execution
@ebb-earl-co
Merge Upstream Branch trunk into develop (#157)
37c0827 
* Put back 'macOS [m]' in login.py prompt
@ebb-earl-co
Fix typo of tidal-wave in README.md
eff6054 
It had been `tidal_wave` in the Docker run instructions
@ebb-earl-co
Make README.md Changes
b9302b9 
Point out the `--transparent` flag feature, a couple of other things, and update the TIDAL pricing plans documentation
@ebb-earl-co
Merge branch 'trunk' into develop
d59491c
@ebb-earl-co
Format playlist.py with Black
89888bb
@ebb-earl-co
Format mix.py with Black
08fe2a7
@ebb-earl-co
Format video.py with Black
2b2c4d2
@ebb-earl-co
Format album.py with Black
bf5fb2b
@ebb-earl-co
Merge Upstream Branch trunk into develop (#159)
f628d71 
* Hotfix: Update BUILDME.md

Add section about using media-autobuild_suite for compiling FFmpeg on Windows
@ebb-earl-co
Create SHA256 Checksum Files for Release Binaries (#160)
7bf8bd8 
* Pyinstaller binaries

Remove BUILDME.md and README.md from executables
Add creation of SHA256 checksum file

* Fix Path --> WindowsPath in .github/workflows/pyinstaller-windows.yml
@ebb-earl-co
Fix double-quote typos in pyinstaller-*.yml
e8a6371
@ebb-earl-co
Use Path instead of WindowsPath in pyinstaller-windows.yml
134289d
@ebb-earl-co
In pyinstaller-*.yml, cat the checksum file
c0528f9
@ebb-earl-co
Add fetching of original, highest-resolution album cover
bef5d91
@ebb-earl-co
Merge upstream branch, trunk, into develop
0943b7c
@ebb-earl-co
Add logic in python-lint.yml to avoid Python 3.8 on macOS aarch64
91b211a
@ebb-earl-co
Add missing '=' to python-lint.yml
f6afb22
@ebb-earl-co
Use single quotes in python-lint.yml if expression
44ec31d
@ebb-earl-co
Actually, now versions 3.8 AND 3.9 are unsupported on macOS aarch64
2ca8b04
@ebb-earl-co
Multiple-condition Booleans are hard...
cb5894d
@ebb-earl-co
Remove Python 3.13-alpha from python-lint.yml matrix
25a52cf
@ebb-earl-co
Exclude some versions from building on Windows in python-lint.yml
c60bf03
@ebb-earl-co
Booleans are even harder
7ce4cbb
ebb-earl-co and others added 27 commits May 1, 2024 15:22
@ebb-earl-co
Merge branch 'trunk' into develop
b8b5c83
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump m3u8 (#167)
14487e2 
Bumps [m3u8](https://github.com/globocom/m3u8) from 4.1.0 to 5.0.0.
- [Release notes](https://github.com/globocom/m3u8/releases)
- [Commits](globocom/m3u8@4.1.0...5.0.0)

---
updated-dependencies:
- dependency-name: m3u8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump platformdirs (#168)
7a9be74 
Bumps [platformdirs](https://github.com/platformdirs/platformdirs) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/platformdirs/platformdirs/releases)
- [Changelog](https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst)
- [Commits](platformdirs/platformdirs@4.2.1...4.2.2)

---
updated-dependencies:
- dependency-name: platformdirs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Remove Redundant Attribute Declaration in video.py
19eee37 
`self.filename` was duplicated in video.Video.set_filename()
@ebb-earl-co
Update pyinstaller-linux.yml to ubuntu-24.04
87e9bda
@ebb-earl-co
Update python-build.yml to ubuntu-24.04
46f0496
@ebb-earl-co
Update docker-image.yml to 24.04
cbb9c3f
@ebb-earl-co
Update to Python 3.12.3:
9223a09 
In .github/workflows/*.yml, use Python 3.12.3 in PyInstaller builds because Ubuntu 24.04 runner only has this version of Python 3.12
Reference this version in README.md
@dependabot
--- (#171)
1f1cc89 
updated-dependencies:
- dependency-name: requests[socks]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
--- (#172)
12fc078 
updated-dependencies:
- dependency-name: requests[socks]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Bump version of PyInstaller to 6.7.0
12bb3c0
@ebb-earl-co
Update pyproject.toml: Bump Version
007398d
@ebb-earl-co
Merge branch 'trunk' into develop
f37af60
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump requests[socks] (#…
f3bf857 
…175)

Bumps [requests[socks]](https://github.com/psf/requests) from 2.32.2 to 2.32.3.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.32.2...v2.32.3)

---
updated-dependencies:
- dependency-name: requests[socks]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Bring in Upstream Changes from trunk (#176)
43937ef 
* Bump Version for Next Release (#174)

* Update pyproject.toml: Bump Version

* Update pyinstaller-linux.yml: ubuntu-24.04

* Update README.md: Reference ubuntu_24.04
@ebb-earl-co
Use track's title instead of sanitized 'name' in mutagen metadata
3f355fe
@dependabot
Bump docker/login-action from 3.1.0 to 3.2.0 (#178)
e926c16 
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@e92390c...0d4c9c5)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Add artifact uploading and YAML linting to GitHub Actions Workflows
d48d334
@ebb-earl-co
Merge in upstream 'trunk'
3fb55b9
@dependabot
Bump docker/build-push-action from 5 to 6 (#183)
7e1d038 
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v5...v6)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependabot monitoring PyPi dependencies(deps): Bump m3u8 (#182)
9d9d6ce 
Bumps [m3u8](https://github.com/globocom/m3u8) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/globocom/m3u8/releases)
- [Commits](globocom/m3u8@5.0.0...5.1.0)

---
updated-dependencies:
- dependency-name: m3u8
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ebb-earl-co
Allow TIDAL Artists to Parse 3-Digit IDs
ca0a0fd 
Just run across John Williams, of Star Wars composing fame, with the TIDAL artist ID of `160`. This should be valid, so this commit allows 3-digit to 9-digit artist IDs
@ebb-earl-co
Update models.py
9d8af70 
Valid artist IDs are as few as 2 digits!
@ebb-earl-co
Similar to artists, there are albums with 2-digit IDs!
139b6b9
@ebb-earl-co
Merge upstream branch 'trunk' into develop
a20505f
@ebb-earl-co
Disallow Python 3.13 from pyproject.toml:
326b067 
Upon testing with local virtual environments, a 'private' function in stdlib dataclasses, _create_fn, is not recognized by extant version of Python 3.13.
@ebb-earl-co
Workaround for forward slash in artist name (#187)
c577775 
Use the word "and" instead of the forward slash
@ebb-earl-co ebb-earl-co self-assigned this Jul 20, 2024
@ebb-earl-co ebb-earl-co merged commit fe80636 into trunk Jul 20, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ebb-earl-co ebb-earl-co

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ebb-earl-co