Switch to cypress image #5318
Closed
Switch to cypress image #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
added
the
test-flaky-e2e!
manuelmeister
removed
the
test-flaky-e2e!
BacLuc
requested changes
Jun 9, 2024
Comment on lines
9
to
11
| runs-on: ubuntu-22.04 | ||
| container: | ||
| image: cypress/browsers:node-20.13.1-chrome-125.0.6422.60-1-ff-126.0-edge-125.0.2535.51-1 |
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-22.04 | |
| container: | |
| image: cypress/browsers:node-20.13.1-chrome-125.0.6422.60-1-ff-126.0-edge-125.0.2535.51-1 | |
| runs-on: ubuntu-22.04 |
To build the e2e images, we don't want the cypress image.
We want access to an environment which can build OCI (Open Container Initiative) images fast.
manuelmeister
force-pushed
the
fix/cypress-flakyness
branch
from
eb420db
to
2802e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve #5284