-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use paratest for parallel test execution #5372
base: devel
Are you sure you want to change the base?
Use paratest for parallel test execution #5372
Conversation
d4a111d
to
151eb79
Compare
151eb79
to
4d750bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Can I also use this to run tests in parallel on my local machine?
@usu Yes, but you would need to setup the databases |
I realized that from 39410e3 (update phpunit from v10.5.20 to v10.5.21, main feature: sebastianbergmann/phpunit#5861) the test only takes 3m 19s, instead of 14m 34s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the unnecessary change and the change in dev/doctrine.yaml, and i am happy.
Tested it locally, and it ran out of memory when it tried to merge the coverage.
But most of us will anyway not run the tests locally anymore, it takes too much time.
But running the tests locally without paratest still works
POSTGRES_PASSWORD: 'ecamp3' | ||
POSTGRES_USER: 'ecamp3' | ||
POSTGRES_DB: 'ecamp3test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this unnecessary change.
Else future devs might think that this change is needed.
doctrine: | ||
dbal: | ||
# "TEST_TOKEN" is typically set by ParaTest | ||
dbname_suffix: 'dev%env(default::TEST_TOKEN)%' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think you need the test token for dev
To speed up our api tests, I've parallelized them with paratest. It works quite good. Has to be tested, if it actually tests, as the duration seems fishy